Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation on Ubuntu 22.04 #4

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

melhindi
Copy link
Contributor

I had several issues when using this role with ubuntu 22.04:

  1. Adding the brave repo gpg key used the deprecated add-key function -> Fix addition of gpg key
  2. When adding the repository to the list, apt fails to verify the signature (The following signatures couldn't be verified because the public key is not available) -> Fix adding repository while specifying signing key

With this PR the Debian install tasks exactly mirror the instructions mentioned at https://brave.com/linux/
I tested that things work as expected using DISTRO="ubuntu-22.04" molecule converge

Fix addition of gpg key
Fix adding repository while specifying signing key
Instructions based on https://brave.com/linux/
@darkwizard242
Copy link
Owner

Thank you @melhindi

Looks like all the molecule runs for Ubuntu (18.04/20.04), Rocky Linux (7/8) and Debian (stretch/buster) have passed. Can you please update the role's metadata to include jammy (i.e. 22.04) as a supported version and push another commit?

@darkwizard242
Copy link
Owner

Additionally, please also update the build-and-test workflow to include ubuntu-22.04

@darkwizard242 darkwizard242 merged commit cb439d7 into darkwizard242:master Oct 3, 2022
darkwizard242 added a commit that referenced this pull request Oct 3, 2022
@darkwizard242
Copy link
Owner

@melhindi - Checks passed. Release version 2.1.0, should now be in Ansible Galaxy as the latest available version.

Thank you for your contribution 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants